Add tests for non-square cells#254
Merged
Merged
Conversation
lrntct
commented
Jun 25, 2026
lrntct
commented
Contributor
- Added regression test for solve_h: it sets known qe/qs values on a 5x5 stencil and checks the center-cell depth update matches ((qw - qe) / dx) + ((qn - qs) / dy). It also verifies the result would differ if dx and dy were mistakenly swapped.
- Added a small helper that builds a 5x5 simulation with arbitrary dx/dy. The helper keeps the initial water volume constant across runs, so the comparisons isolate cell-shape effects.
- Added test_rectangular_cells_preserve_axis_symmetry_and_bias_early_spreading. Checks top == bottom and left == right. Checks spreading is stronger along the axis with the smaller cell size.
- Added test_swapping_dx_and_dy_transposes_the_early_time_solution. Compares (dx, dy) = (20, 10) against (10, 20) and asserts the early-time water-depth field is transposed when the cell sizes are swapped.
- Resolves Add tests for non-square cells #122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.